[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] Fixes for build/install system



Christoph Egger writes ("[PATCH] Fixes for build/install system"):
> Attached patches get rid of hardcoded install path,
> fixes wrong install paths and replaces mkdir -p with $(INSTALL_DIR).
> All in all, a command like PREFIX="/usr/local" gmake dist
> now installs everything into dist/install/usr/local
> instead of dist/install/usr

This is all very nice but

>  install-doc: $(DOCS)
> -     mkdir -p "$(DESTDIR)$(docdir)"
> +     $(INSTALL_DIR) "$(DESTDIR)$(docdir)"
>       $(INSTALL) -m 644 qemu-doc.html  qemu-tech.html "$(DESTDIR)$(docdir)"

these are parts of the Makefile which come from upstream qemu.
I definitely don't want to modify those parts.  Everything which is
done in the makefiles in qemu-xen-unstable is aimed at avoiding large
textual changes which make merging difficult.  We don't want changes
in our versions of the upstream makefiles which are not absolutely
necessary to make things work.

It's not clear to me by inspection whether I can safely apply the
other parts of your qemu patch on their own.  Can you confirm ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.