Re: [Xen-devel] [PATCH] Check for valid CPU_CAP value when creating(constructing) new domain

[Michal Novotny <minovotn@xxxxxxxxxx>]

Hi Kan,
looks fine to me. Sorry about indents - I forgot I was writing it in 
gedit now and not Midnight Commander editor - and that I forgot about 
scheduler type.
Best regards,
  Michal

Masaki Kanno wrote:
> Hi Michal,
>
> I have added the following fixes to your patch.
>  - Check scheduler type
>  - Replace tab-indent with space-indent
>
> How about the patch?
>
> Signed-off-by: Michal Novotny <minovotn@xxxxxxxxxx>
> Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
>
> Best regards,
>  Kan
>
>
> Mon, 30 Mar 2009 09:35:42 +0200, Michal Novotny wrote:
>
>   
> > Hi Kan,
> > this is new version of my patch implementing check for both CPU_CAP and 
> > CPU_WEIGHT and also considering int type for both (asserting it).
> > Best regards,
> > Michal
> >
> > Masaki Kanno wrote:
> >     
> > > Hi Michal,
> > >
> > > Why does the patch implement only CPU_CAP?
> > > You should consider CPU_WEIGHT too.
> > > And you should consider scheduler types too.
> > >
> > > Best regards,
> > >  Kan
> > >
> > > Mon, 30 Mar 2009 08:43:07 +0200, Michal Novotny wrote:
> > >
> > >   
> > >       
> > > > Hi,
> > > >
> > > > This patch implements check for valid cpu_cap value when creating domain (
> > > > in range 0 to VcpuCount * 100 as when changing scheduler parameters).
> > > >
> > > > Signed-off-by: Michal Novotny <minovotn@xxxxxxxxxx>
> > > >
> > > >
> > > > -------------------------------text/plain-------------------------------
> > > > _______________________________________________
> > > > Xen-devel mailing list
> > > > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > > > http://lists.xensource.com/xen-devel
> > > >     
> > > >         
> > >   
> > >       
> > -------------------------------text/plain-------------------------------
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> >     

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel