Re: [Xen-devel] [PATCH] Fix domheap structure allocation when NUMA=on

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 20/03/2009 09:27, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> Since DIRECTMAP_VIRT_END is always the following byte not the last byte, it
>> sounds like you think the page_alloc.c chunk is not needed at all. I'll just
>> check in the header fix for now.
> 
> No, that chunk is necessary afaics - as I said I agree to Xiaowei's diagnosis
> that virt_to_mfn() should not be used on DIRECTMAP_VIRT_END alone.
> Subtracting 1 from it, and then adding back 1 to the result is indeed what
> I think is the right thing to do here.

Ah... virt_to_mfn() has a discontinuity at DIRECTMAP_VIRT_END. I get you.
I'll apply that chunk as a separate changeset then.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel