[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] linux/PCI-MSI: fix compiler warnings resulting from c/s 790



The one in pci_enable_msix() is rather meaningful, as the uninitialized
inner msi_dev_entry was indeed hiding the initialized outer one.

As usual, written and tested on 2.6.29-rc8 and made apply to the 2.6.18
tree without further testing.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- head-2009-03-18.orig/drivers/pci/msi-xen.c  2009-03-18 16:08:41.000000000 
+0100
+++ head-2009-03-18/drivers/pci/msi-xen.c       2009-03-18 17:30:44.000000000 
+0100
@@ -612,7 +612,6 @@ int pci_enable_msix(struct pci_dev* dev,
 
 #ifdef CONFIG_XEN_PCIDEV_FRONTEND
        if (!is_initial_xendomain()) {
-               struct msi_dev_list *msi_dev_entry;
                struct msi_pirq_entry *pirq_entry;
                int ret, irq;
 
@@ -625,7 +624,6 @@ int pci_enable_msix(struct pci_dev* dev,
                }
                msi_dev_entry->default_irq = temp;
 
-               msi_dev_entry = get_msi_dev_pirq_list(dev);
                for (i = 0; i < nvec; i++) {
                        int mapped = 0;
 
@@ -688,8 +686,6 @@ void pci_disable_msix(struct pci_dev* dev
 {
        int pos;
        u16 control;
-       struct msi_dev_list *msi_dev_entry = get_msi_dev_pirq_list(dev);
-
 
        if (!pci_msi_enable)
                return;




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.