[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH][RFC] Parameter name change for xc_*_build functions


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
  • Date: Mon, 16 Mar 2009 15:50:50 +0000
  • Delivery-date: Mon, 16 Mar 2009 08:51:19 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; b=bfd08XkOc/KWkZ2JLWEMaNP/HL88pjy9qMtGjLVn99PZLbWDNaTfQUyQrsmAgDIP4u hdfnjVxAObERwwOYlEGx7LNgVt9Nb2/5drFQsVAPKzJOKL9N4rmn/PRh1KBy5sPhGP90 aFsziAoAuszsCFTdgdWWhMEMV7wF3whp3RVsI=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

[Purely a cosmetic change.]

It's been pointed out that the "memory" parameter names in
tools/libxc/xenguest.h aren't very consistent between linux and HVM,
and may confuse people setting up ballooning systems.  Ballooning
systems generally have a parameter like "static_max", which is the
maximum memory the VM will ever have, and "target" which is the memory
we want it to have right now (somewhere between dynamic_max and
dynamic_min).

The attached patch changes the parameter names to make them consistent
with what someone building such a system might use:
* When building a PV Linux VM, since we can expand the memory whenever
we wish, we pass in "start_mem_mb".  This corresponds to "target".
* When building an HVM VM with xc_hvm_build(), since we cannot grow
larger than the initial amount of memory at boot, we pass in
"max_mem_mb".  This corresponds to "static_max".  The balloon driver
can then be used after boot to balloon down to target.
* When building an HVM VM with xc_hvm_build_target_mem(), we pass both
parameters: "max_mem_mb" (which corresponds to "static_max") and
"start_mem_mb" (which corresponds to target).

Thoughts?

 -George Dunlap

Attachment: parameter-names.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.