Re: [Xen-devel] [PATCH] Domain core-dumping fixes

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi John,

>> Please don't reset a domain after unpaused the domain.
>
>I must admit I don't really understand what this option is for.
>

The reset option cuts down the number of operations for users.

 Without the reset option:
   1) xm dump-core --crash vm1
   2) xm create/start vm1

 With the reset option:
   1) xm dump-core --reset vm1

If a crashed guest works between unpause and reset,
then the guest system may corrupt.
So we want to reset the crashed guest before unpause.
If we cannot do that, the reset option is worthless.
May I remove the reset option from xm dump-core command?

>> Could you move the reset into xend?
>
>Not without breaking backwards compatibility. Unfortunately, the xend
>code in server/SrvDomain.py (I think) does not allow optional arguments:
>so every time you add a parameter like 'reset' (which is not there now),
>every client breaks. In particular, libvirt.
>

I cannot complain. 
Should we not add options for clients anymore?

Will anyone improve server/SrvDomain.py?

Best regards,
 Kan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel