Re: [Xen-devel][PATCH][RFC] _chk_fail and _chk canaries for minios and newlib

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

George S. Coker, II, le Mon 09 Mar 2009 14:28:22 -0500, a écrit :
> It probably isn't enough.  It's more of a stub to make the linker and
> libraries happy.

Right, in this particular case it's read-only code so it shouldn't
harm so much and the code could be checked-in as is.  I'm however
wondering how these reads do not trigger traps, as we unmap page 0 in
clear_bootstrap(), and thus e.g. on i386 gs:0x14 should trap.

> I was a little uncertain about the split between minios and newlib.

The way you did it seems right to me: checking printf size is more a
matter of newlib, while reacting to stack smashing is a kernel matter.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel