Re: [Xen-devel] [PATCH] hvm/vpt: Check that an irq is not blocked before waking the vcpu

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 09/03/2009 11:45, "George Dunlap" <George.Dunlap@xxxxxxxxxxxxx> wrote:

> Currently, when a timer fires for a vpt interrupt, the interrupt
> handler calls vcpu_kick() without checking to see if the IRQ is
> blocked.  This causes the vcpu to wake up out of a halt when it
> shouldn't.
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Only one question: could this race an unmask operation? Before this patch,
pt_irq_masked() is only executed for the local vcpu, so such races may not
have been considered.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel