Re: [Xen-devel] [PATCH] xen: mask XSAVE in cpuid since we don't allowguests to use it

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Jeremy Fitzhardinge <jeremy@xxxxxxxx> 08.03.09 06:31 >>>
>Mask X86_FEATURE_XSAVE in cpuid leaf 1, ecx, as we don't allow guests to
>use it (by setting cr4.OSXSAVE).

I actually disagree to this. The kernel should be dealing with the situation
by inspecting the OSXSAVE bit in CPUID when running under Xen, since it's
really Xen that's the 'OS' for that particular feature.

Then, once Keir gets willing to take Intel xsave patch(es), no further change
is going to be needed here. And the same kernel will work (assuming it has
no other dependencies) on older Xen not having this bit masked.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel