Re: [Xen-devel] [PATCH] Do not set page's count_info directly

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 05/03/2009 12:32, "Gianluca Guida" <glguida@xxxxxxxxx> wrote:

>> Also currently shadow code assume count_info is 0 for shadow page, however,
>> this is invalid after the new flags. Change some assert in shadow code.
> 
> Yes, that's correct. I find, though, (count_info & PGC_count_mask !=
> 0) as a check if the page is a shadow *very* confusing. Could you
> define a macro with something like page_is_a_shadow_page() and hide
> this mm.c dirty secret?

This would be a shadow-code-specific macro. In general count_mask==0 can
also mean the page is free, for example.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel