Re: [Xen-devel] Re: [PATCH]Add a flag for shadow pages

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 04/03/2009 12:13, "Tim Deegan" <Tim.Deegan@xxxxxxxxxxxxx> wrote:

> shadow_get_page_from_l1e() should never be handling a pointer to a
> shadow -- if it does that then we've let the guest see the shadows and
> all invariants go out the window.
> 
> sh_mfn_is_a_pagetable() looks OK too; it only gets called based on the
> contents of shadow PTEs or the MFNs that guests are writing to, both of
> which should be safe.
> 
> It all feels a bit fragile to me though, compared to the old layout
> where we always knew the owner field would be NULL.

This is the tradeoff for the new get_page() implementation and wider
reference counts. We just need to be careful and use
page_get_owner_and_reference() in the few cases it seems to be needed.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel