Re: [Xen-devel] Re: [PATCH] ioemu: Cleanup the code of PCI passthrough.

[Simon Horman <horms@xxxxxxxxxxxx>]

On Mon, Feb 23, 2009 at 10:40:22AM +0900, Yuji Shimada wrote:
> 
> The patch cleanups the code of PCI passthrough.
> 
> - Use LIST_FOREACH(). Don't use lh_first, le_next directly.
> - Use pci_{read, write}_block instead of "switch(len) case [124]
>   pci_{read, write}_{byte, word, long}();".
> - Eliminate duplicate codes using PT_MEARGE_VALUE macro.
> - Define PCI_ERR_* macro in pass-through.h if libpci is old.
> - Remove the unreasonable loop from pt_aer_reg_{save,restore}.
> - Enable pt_aer_reg_{save,restore}, even if libpci is old.
> - Fix ro_mask and remove unnecessary pt_xxx_reg_write functions.
> - Add "Error:" or "Warning:" to messages.
> - Remove verbose messages.
> 
> Thanks,
> --
> Yuji Shimada.
> 
> 
> Signed-off-by: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>

Tested-by: Simon Horman <horms@xxxxxxxxxxxx>

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel