Re: [Xen-devel] [PATCH] pygrub: parse xen module option in grub

[Wei Kong <weikong.cn@xxxxxxxxx>]

2009/2/20 John Levon <levon@xxxxxxxxxxxxxxxxx>

On Fri, Feb 20, 2009 at 10:40:14AM +0800, Wei Kong wrote:

> Add function for GrubConf to parse xen module option in grub.

Why?

thanks, John
 

Maybe that "guest" doesn't have right kernel pattern as xen module.
o, the "guest" means an os on a phy partition which never be a guest before.
Due to sometimes I have many os on different partitions, but I haven't any guest and I don't want install one,
so just let xen boot any exist os as guest.  

 

> Pygrub should pass args as domUloader did.

domUloader was never in the tree.

> -            sxp += "(args \"%s\")" % chosencfg["args"]

> +            sxp += "(args \"%s %s\")" % (chosencfg["args"], incfg["args"])

Are you trying to let the user add arguments to the ones specified in
grub? Why?

Yes, this args is the one user want to pass to guest kernel, 
domUloader real did this, and sorry for I don't know domUloader isn't in this tree.
 

The patch is wrong anyway, you can't just add on the incoming args for
Solaris at least. At the very least you need to add the args only when
run_grub() is called.

No, I didn't add any args for solaris.
Because I don't want to add args for Solaris, so I add args here, not in run_grub(). 

--thanks a lot
Kong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel