[Xen-devel] Re: [PATCH 0 of 7] x86/paravirt: optimise pvop calls and register use

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

H. Peter Anvin wrote:
> The failing configuration was x86-64 "make allyesconfig".
>
>         -hpa
>   
Subject: x86/paravirt: fix missing callee-save call on pud_val

Fix missed convertion to using callee-saved calls for pud_val, which
causes a compile error when CONFIG_PARAVIRT_DEBUG is enabled.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
diff -r 452b0aa6f629 arch/x86/include/asm/paravirt.h
--- a/arch/x86/include/asm/paravirt.h   Wed Jan 28 14:18:52 2009 -0800
+++ b/arch/x86/include/asm/paravirt.h   Thu Jan 29 01:49:37 2009 -0800
@@ -1321,11 +1321,11 @@
        pudval_t ret;

        if (sizeof(pudval_t) > sizeof(long))
-               ret =  PVOP_CALL2(pudval_t, pv_mmu_ops.pud_val,
-                                 pud.pud, (u64)pud.pud >> 32);
+               ret =  PVOP_CALLEE2(pudval_t, pv_mmu_ops.pud_val,
+                                   pud.pud, (u64)pud.pud >> 32);
        else
-               ret =  PVOP_CALL1(pudval_t, pv_mmu_ops.pud_val,
-                                 pud.pud);
+               ret =  PVOP_CALLEE1(pudval_t, pv_mmu_ops.pud_val,
+                                   pud.pud);

        return ret;
}



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel