[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] RE: tboot support broken by c/s 19075
On 29/01/2009 00:31, "Cihula, Joseph" <joseph.cihula@xxxxxxxxx> wrote: > If this path is taken then bzimage_check() will return -22 (EINVAL is 22), > which bzimage_headroom() will then return, which gets assigned to > modules_headroom in __start_xen() and modules_headroom is an unsigned > long--hence it will get a very large value. I think that all failure paths in > bzimage_headroom() should return 0? I suspect callers of bzimage_headroom() are supposed to check for negative return values. Seems easier just to return 0 really, as you suggest. Of course, this isn't your actual bug. :-( -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |