[Xen-devel] Re: [PATCH] txt: 6/6 - hypervisor integrity on S3

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 20/01/2009 05:50, "Cihula, Joseph" <joseph.cihula@xxxxxxxxx> wrote:

> When launched from tboot, utilise tboot interface to provide integrity
> protection to the hypervisor during S3
> 
> Signed-off-by: Joseph Cihula <joseph.cihula@xxxxxxxxx>
> ACKed-by: Shane Wang <shane.wang@xxxxxxxxx>
> 
> +        g_tboot_shared->mac_regions[1].start = (uint64_t)xen_phys_start;
> +        g_tboot_shared->mac_regions[1].end = (uint64_t)xenheap_phys_end;
> +    }

Looks like the only place you use the xen_phys_start and xenheap_phys_end.
Of course xenheap_phys_* no longer even exist on x86/64. The best you can do
I think is [__pa(&_start), __pa(&_end)]. If you want to do better for i386
(though frankly hardly anyone uses that build) then you can use
[xenheap_phys_start, xenheap_phys_end] and update xenheap_phys_start to
(1ul<<20) in setup.c. Please leave xen_phys_start alone and don't use it.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel