Re: [Xen-devel] [Patch 2 of 2]: PV-domain SMP performance Linux-part

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Juergen Gross <juergen.gross@xxxxxxxxxxxxxxxxxxx> 18.12.08 08:18 >>>
>Jan Beulich wrote:
>> 
>>> +           _vcpu->no_desched = 0;                                  \
>>> +           _vcpu->evtchn_upcall_mask = 0;                          \
>>>             barrier(); /* unmask then check (avoid races) */        \
>>> +           if ( unlikely(_vcpu->desched_delay) )                   \
>>> +                   (void)((HYPERVISOR_sched_op(SCHEDOP_yield, _vcpu))?:0); 
>>> \
>> 
>> Why not just cast the function result to void? Likewise further below...
>
>I took that from include/xen/hypercall.h, which mentioned problems with just
>casting the function result.

Ah, yes, I recall. But then why don't you use that macro? After all, hypercall.h
must have been included if you're able to call HYPERVISOR_sched_op().

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel