Re: [Xen-devel] [PATCH 1/1] Xen PV support for hugepages

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 6/11/08 13:44, "Dave McCracken" <dcm@xxxxxxxx> wrote:

>> Also, the special code to deal with LDT pages in put_page_from_l1e() should
>> now also be required in put_page_from_l2e(). Perhaps that logic could be
>> moved into put_data_page()?
> 
> It looks to me like this is only done for PGT_seg_desc_page.  I don't think
> any hugepage can be of this type.  I can add it to put_data_page() if you
> think we need to be sure.

The data pages mapped by a superpage mapping aren't special. One of them
could certainly be PGT_seg_desc_page. Hence moving the logic into
put_data_page() makes sense.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel