Re: [Xen-devel] [PATCH] x86: fix preemptable page type handling(v2)

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 30.10.08 15:46 >>>
>Why does this patch not do what the new comment says and directly get_page()
>when PGT_partial is set and put_page() when PGT_partial is cleared? Doing

Hmm, the description was meant to tell the net effect, not the way it's
implemented.

>get_page() across all __put_page() operations and then skipping the
>put_page() in some cases, for example, seems inefficient and also makes the
>code less clear. Why would you do it that way?

Because I can't handle a failure of get_page() (due to count overflow)
once I'm past the put()s.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel