[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] x86: fix domain cleanup
On 28/10/08 10:05, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: >> Ah, looks like it's been broken since the preemptible page_type patch went >> in. Perhaps the tail of free_page_type() should go into __put_page_type(), >> as it's not needed by the call site in relinquish_memory(): the caller >> doesn't really hold a type reference to be dropped; and the logic for being >> preempted doesn't apply since relinquish_memory() requests no preemption. > > It doesn't at present, but it should (in favor of > DOMAIN_DESTRUCT_AVOID_RECURSION), > including the put_page_and_type() earlier in that function. But of course, > it may still turn out that cleaning up after preemption here must be handled > differently from the __put_page_type() case. I'll give moving that part > (and removing the put_page() added yesterday) a try. __put_page_type() is already a complex function actually, so let's define a __put_final_page_type() containing a call to free_page_type() plus the current tail of free_page_type(). __put_page_type() can call that; relinquish memory can call free_page_type() directly. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |