[Xen-devel] Re: [PATCH] Share the IO_APIC_route_entry with iosapic

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

If the code using this definition will be shared too, that's one thing. If
you're actually going to put all the code under arch/ia64 (which you seem to
imply), then duplicating this structure in include/asm-ia64 is okay. It's
not like it's changing, ever. I personally think that striving to share
architectural definitions in all cases, even where that may twist the header
#includes, is not necessarily a good idea. So it depends what your end goal
is.

 -- Keir

On 28/9/08 07:52, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> The patch moves the struct IO_APIC_route_entry to a common place.
> This allows us to share the struct with iosapic.
> 
> Thanks,
> -- Dexuan
> 
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel