Re: [Xen-devel] [PATCH] gnttab_setup_table error case

[Diego Ongaro <diego.ongaro@xxxxxxxxxx>]

Samuel Thibault wrote:
> Qing He, le Thu 31 Jul 2008 10:08:28 +0800, a écrit :
>> On Wed, 2008-07-30 at 14:17 +0100, Diego Ongaro wrote:
>>> gnttab_setup_table should set an error status code if the gmfn it gets
>>> for a grant table page is invalid.
>>>
>>> I ran into this issue when I tried to set up the grant table during hvm
>>> domain creation, and it caused a BUG_ON later down the line. With this
>>> patch, the hypercall will gracefully fail instead.
>> Do you use 32bit guest on top of 64bit hypervisor?
> 
> No, just 64/64.

Well, no, it was 32 on 64 :)

>> Just curious, but why we want to call setup_table in HVM in the first
>> place. Since HVM has its isolated address space, it will always fail.
> 
> That was for his personal project.  The call was made from dom0.  The
> problem is that it triggers a BUG_ON, which we do not really want to
> happen :)

Keir's xen-unstable.hg cs 18177:9ee2e41a68a1 simply removed the
problematic BUG_ON, so at least userspace can now handle the error.

-Diego

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel