Re: [Xen-devel] [PATCH] serialize suspend-resume process

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 31/7/08 12:57, "BVK Chaitanya" <bayapuneni_chaitanya@xxxxxxxxxxxx> wrote:

> Yes, but there must be a way for dom0 to know that suspend-resume cycle
> is completed.  Currently dom0 only gets suspend completed notification
> -- as part of shutdown hypercall -- but no resume
> (xenbus_suspend_cancel) completed notification.
> 
> If dom0 issues second suspend request before resume is completed a _new_
> kthread is started and will proceed with xen_suspend in parallel.  I saw
> this hitting BUG_ON in netfront_accelerator_add_watch.

That isn't true. xen_suspend() can only be re-entered after it has switched
the 'shutting_down' variable to SHUTDOWN_INVALID. At this point resume work
is completed (except perhaps for resuming some PV devices via xenbus, which
is done asynchronously).

Your BUG_ON() may be fixed by linux-2.6.18-xen.hg, changeset 622.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel