Re: Patch attachment format (was Re: [Xen-devel] [PATCH] Fix issues when passthrough device is hot-removed from HVM domain.)

[Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>]

Thank you for your kind advice.
I changed the MIME setting.

Thanks.

--
Yuji Shimada

On Fri, 18 Jul 2008 15:15:20 +0100
Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> Yuji Shimada writes ("[Xen-devel] [PATCH] Fix issues when passthrough device 
> is hot-removed from HVM domain."):
> > When passthrough device is hot removed from HVM domain by "xm
> > pci-detach" command, following issues occur. The patch fixes them.
> >    - Allocated memory is not deallocated.
> >    - Unbind interrupt with invalid interrupt pin.
> >    - MSI-X memory mapped register area is not unmapped.
> 
> Thanks for this patch.
> 
> However can you please ask your program to stop marking these patches
> as if they were opaque binary data attachments ?  That makes it hard
> for other people using normal mailreaders to review your changes -
> sometimes we even have to save the patch to a file, because your
> mailer has tagged it as if it were a binary file like a kernel image
> or something.
> 
> I don't know how to achieve this with your mailer, but it's possible
> that changing the patch filename from `*.patch' to `*.txt' will help.
> 
> (At a technical level, what I'm complaining about is this MIME data
> for the body part containing the patch:
>     Content-Type: application/octet-stream;
>      name="fix_hot-remove.patch"
>     Content-Disposition: attachment;
>      filename="fix_hot-remove.patch"
> `application/octet-stream' is wrong and should read `text/plain', or
> perhaps `text/x-patch' or something.)
> 
> Thanks,
> Ian.

Attachment: mime-test.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel