[Xen-devel] Re: [Patch] ioemu-remote: fix gcc4 build problem (?)

[Andre Przywara <andre.przywara@xxxxxxx>]

Ian Jackson wrote:
> Andre Przywara writes ("Re: [Patch] ioemu-remote: fix gcc4 build problem (?)"):
> > I tried these both version. It says I am up-to-date.
> How odd.
Right you are. Now it works... Have you changed something on the servers 
since yesterday?
I have checked commit b5123e05cce4be4c6c8c822fad0f0df4c053da06 (With 
--disable-gcc-check, do not produce spurious errors if no GCC3 at all.)
To be honest this is almost the same fix I had created in the first try, 
but later I found the far more elegant fix in upstream QEMU:
--- configure.old       2008-07-21 15:45:25.000000000 +0200
+++ configure.qemu      2008-07-21 15:44:31.000000000 +0200
@@ -1241,7 +1241,7 @@
     fi
     echo "#define CONFIG_DYNGEN_OP 1" >> $config_h
     gcc3minver=`$cc --version 2> /dev/null| fgrep "(GCC) 3." | awk '{ 
print $3 }' | cut -f2 -d.`
-    if test -n "$gcc3minver" -a $gcc3minver -gt 3
+    if test -n "$gcc3minver" && test $gcc3minver -gt 3
     then
       echo "HAVE_GT_GCC_3_3=true" >> $config_mak
     else

Mmmh, shouldn't that be -ge instead of -gt?

Attached a version against the current ;-) git head.
I think it is much cleaner and the same as in upstream QEMU.

Regards,
Andre.

--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

diff --git a/configure b/configure
index 9ff039e..226a65e 100755
--- a/configure
+++ b/configure
@@ -1250,16 +1250,11 @@ case "$target_cpu" in
     fi
     echo "#define CONFIG_DYNGEN_OP 1" >> $config_h
     gcc3minver=`$cc --version 2> /dev/null| fgrep "(GCC) 3." | awk '{ print $3 
}' | cut -f2 -d.`
-    if test -n "$gcc3minver"
+    if test -n "$gcc3minver" && test $gcc3minver -gt 3
     then
-      if test -a $gcc3minver -gt 3;
-      then
-        echo "HAVE_GT_GCC_3_3=true" >> $config_mak
-      else
-        echo "HAVE_GT_GCC_3_3=false" >> $config_mak
-      fi
-    else
       echo "HAVE_GT_GCC_3_3=true" >> $config_mak
+    else
+      echo "HAVE_GT_GCC_3_3=false" >> $config_mak
     fi
   ;;
   x86_64)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel