RE: [Xen-devel] [PATCH] Improve the current FLR logic

["Cui, Dexuan" <dexuan.cui@xxxxxxxxx>]

Yuji Shimada wrote:
> On Fri, 18 Jul 2008 14:37:30 +0800
> "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:
> 
>> Now xend saves and restores all the 256-byte space -- this is not
>> suitable as you pointed. How about only saving/restoring the header
>> (the first 64-byte)? 
> 
> I think following registers in PCI Express Capability Structure
> should be restored. The reason is that host firmware might configure
> them. 
> 
>      - Uncorrectable Error Mask Register
>      - Uncorrectable Error Severity Register
>      - Correctable Error Mask Register
>      - Advanced Error Capabilities and Control Register
>      - Device Control Register
>      - Link Control Register
>      - Secondary Uncorrectable Error Severity Register
>      - Secondary Uncorrectable Error Mask Register
>      - Device Control 2 Register
>      - Link Control 2 Register

Hi Yuji,
Thanks for your advice!
To restore the values of the PCIe registers to the original values the
firmware (and Dom0?) configues, we need to store the original values
somewhere. 
Maybe we can restore the info into xenstore?

> What do you think about following method?
> 
>      1. create the table, and fill offset, size, etc. of registers to
>         save/restore into the table.
> 
>      2. save/restore registers based on the table.
This sounds nice.
Where should we store the table?

Thanks,
-- Dexuan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel