[Xen-devel] [PATCH] Improve plumbing for calling external qemu builds

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

* Remove ioemu-dir before replacing it with a symlink so that
  switching between trees doesn't go wrong.
* Remove case-based arrangement for making XEN_ROOT absolute
  and replace with $(abspath ...) since we depend on GNU make
  anyway.
* `make clean' recurses into ioemu-dir

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

diff -r 9b35ae586cb8 tools/Makefile
--- a/tools/Makefile    Mon Jul 07 10:45:50 2008 +0100
+++ b/tools/Makefile    Tue Jul 08 12:08:36 2008 +0100
@@ -79,15 +79,14 @@ ioemu-dir-find:
                        $(GIT) clone $(CONFIG_QEMU) ioemu-remote.tmp; \
                        mv ioemu-remote.tmp ioemu-remote; \
                fi; \
+               rm -f ioemu-dir; \
                ln -sf ioemu-remote ioemu-dir; \
        fi
-       set -e; \
-               case "$XEN_ROOT" in \
-               /*)     XEN_ROOT=$(XEN_ROOT) ;; \
-               *)      XEN_ROOT=`pwd`/$(XEN_ROOT) ;; \
-               esac; \
-               export XEN_ROOT; \
-               cd ioemu-dir; \
-               ./xen-setup
+       cd ioemu-dir && XEN_ROOT="$(abspath $(XEN_ROOT))" ./xen-setup
 
 subdir-all-ioemu-dir subdir-install-ioemu-dir: ioemu-dir-find
+
+subdir-clean-ioemu-dir:
+       if test -d ioemu-dir/.; then \
+               $(MAKE) -C ioemu-dir clean; \
+       fi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel