[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [patch][vtd] Remove ASSERT in hvmloader.c when assigning disk controller to a guest


  • To: "Zhang, Li" <li.zhang@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Wed, 25 Jun 2008 12:31:21 +0100
  • Delivery-date: Wed, 25 Jun 2008 04:32:02 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcjWta1A49gT7Ps4RHaMe8nse4Bn7gAAVCFq
  • Thread-topic: [patch][vtd] Remove ASSERT in hvmloader.c when assigning disk controller to a guest

If the device is not PIIX3 IDE then presumably we should not do the two
pci_writew() invocations either? Words 0x40 and 0x42 in the PCI config space
could have a completely different purpose in a different IDE controller.

 -- Keir

On 25/6/08 12:21, "Zhang, Li" <li.zhang@xxxxxxxxx> wrote:

> Hi, 
> If boot a HVM guest configured with a physical disk, it will check the
> device id of emulated device and then check physical device. But the
> device id of physical device is not necessary 0x7010. So ASSERT may
> fail, and the guest crashes at this point. This patch removes the ASSERT
> of vendor_id and device_id, to assign SATA controller to guest.
> 
> Signed-off-by: Li Zhang <li.zhang@xxxxxxxxx>
> 
> Thanks
> -Li
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.