Re: [Xen-devel] [PATCH][QEMU] Fix HVM guest hang in save/restore with the network load

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

I wrote:
> I'm going to see if I can get our version, which is in some ways more
> elegant, into upstream.

However, I did find what looks like a small mistake, for which this is
the fix:

 diff -r d0817f08599a tools/ioemu/hw/pci.c
 --- a/tools/ioemu/hw/pci.c     Fri May 16 09:37:19 2008 +0100
 +++ b/tools/ioemu/hw/pci.c     Fri May 16 16:48:52 2008 +0100
 @@ -101,7 +101,7 @@ int pci_device_load(PCIDevice *s, QEMUFi
          int i;
          qemu_get_buffer(f, &irq_state, 1);
          for (i = 0; i < 4; i++)
 -            pci_set_irq(s, i, !!(irq_state >> i));
 +            pci_set_irq(s, i, (irq_state >> i) & 1);
      }
      return 0;
  }

The value written to the savefile is a bitmap of irq states, and the
recovery of the relevant bit is not correct.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel