RE: [Xen-devel] [PATCH 0/4] HVM Virtual S3

["Ke, Liping" <liping.ke@xxxxxxxxx>]

Hi, Ian and Keir
Thanks for the detailed explanation.
I have tried below solution according to all feedbacks:
1. merged s3suspend+s3resume+domain_pause phase into one s3_suspend phase 
2. s3 resume phase is now very light. Do something like unpause domain
3. add xm trigger <domid> s3resume interface to for s3_resume operation
4. add new state s3suspended plus (paused, blocked, etc)
All works just fine.

Yet I have met below problems:
1. if hvm in s3suspended, could we allow pause/unpause/suspend/resume operation?
    Need we add condition guard in python code?
2. when we add a new flag is_s3_suspended in dominfo structure, it will affect 
other
Trace/statistic tools in xen, seems this is not a very small change? 
   The above two changes is ok for you or not?

Thanks a lot for your help!
Regards,
Criping


Ian Pratt wrote:
>> Today I am trying this idea, I found combining S3
>> sus/resume+domain_pause, and then
>> use domain_unpause letting domain back works fine.
>> 
>> Yet when I am trying xm save after pausing domain, I found if a
>> domain not running, Xm save will reject the save request.
>> So I want to know whether domain running is a must  for xm save
>> operation?
> 
> Yes, you'll certainly need a few tweaks to the save/restore code.
> 
> Normally save/restore needs to send a notification to the guest such
> that the PV drivers get themselves into a 'safe' state. If the guest
> is in S3, the drivers will already be shutdown (hence safe).
> 
> I think you'll need to add an explicit new state that a VM can be in
> (S3 sleep), and then gate out some of the save code based on that
> state. You'll also need to make sure that the state is saved as part
> of the image written to disk to make sure that when it restored it
> remains in S3 sleep until triggered back to life. [We may want to add
> flags to the xm save/restore commands to incorporate S3 sleep and
> wake up behaviour as part of save restore, but this is just CLI
> sugar.] 
> 
> Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel