Re: [Xen-devel] [PATCH][RFC]Move PCI Configuration Spaces from Dom0 toXen

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> "Shan, Haitao" <haitao.shan@xxxxxxxxx> 10.04.08 11:45 >>>
>Hi, Keir,
>
>This patch will move reading and writing of PCI configuration spaces
>from dom0 to Xen. It also changes VTD code, so that they can touch the
>PCI configuration spaces with proper lock.
>This will also benefit MSI support in Xen.
>Can you give some comments? Thanks!
> <<pci_conf_xen.patch>> 

I don't think this is going to do what you want when the kernel is using
mmconfig, or AMD's extended register space access method (not to
speak of the hopefully not in wide spread use type 2 access method).

Also I find it a little odd that you allow access to ports cf9...cfb rather
than properly handling namely byte accesses to cf9. Likewise it
doesn't consider the (albeit unlikely) case of multi-byte accesses to
ports crossing the cf8/cfc boundary.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel