Re: [Xen-devel] [PATCH] incorrect xfree for mini-os

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 2/4/08 11:52, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxxx> wrote:

> INAKOSHI Hiroya, le Wed 02 Apr 2008 19:43:29 +0900, a écrit :
>> xfree in extras/mini-os/lib/xmalloc.c is incorrect.
>> 
>> It has to check first if the memory to free is so big as to be freed
>> directly by free_pages.
>> 
>> mini-os domains crash without this patch if they don't configure vfb
>> correctly.
>> 
>> Signed-off-by: INAKOSHI Hiroya <inakoshi.hiroya@xxxxxxxxxxxxxx>
> 
> Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>

Applied, but shouldn't the checks that this patch skips work okay even for
big allocations made via xmalloc_whole_pages()? It works okay that way in
Xen itself.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel