Re: [Xen-devel] [RFC][PATCH] domheap optimization for NUMA

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 2/4/08 14:06, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> wrote:

> The issue is alloc_domheap_pages take domain* as parameter to indicate if need
> account pages for the domain, sometimes it's NULL. In this case, we can't
> deduct 
> the node from domain. I believe it's why use cpu here as getting cpuid is
> easier.

Yes, but it's a bad interface, particularlty when the function is called
alloc_domheap_pages_on_node(). Pass in a nodeid. Write a helper function to
work out the nodeid from the domain*.

> Another option, always use domain* to locate node(not allowed NULL) and add a
> new flag _MEMF_assign to indicate the assignment, which changes the interface
> and is invasive.

Yes, that's a bad idea.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel