[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/8] tools - Add generic subdirs rules
On 21/3/08 13:01, "Bastian Blank" <bastian@xxxxxxxxxxxx> wrote: > Add generic subdirs rules. > > Use them in the toplevel Makefile. > > Signed-off-by: Bastian Blank <waldi@xxxxxxxxxx> > diff -r 76c9cf11ce23 -r f08e76266aa7 tools/Rules.mk > --- a/tools/Rules.mk Fri Mar 21 09:45:34 2008 +0000 > +++ b/tools/Rules.mk Fri Mar 21 13:50:27 2008 +0100 > @@ -49,3 +49,13 @@ check-$(CONFIG_X86) = $(call cc-ver-chec > %.o: %.cc > $(CC) $(CPPFLAGS) $(CXXFLAGS) -c -o $@ $< > > +.PHONY: subdirs-all subdirs-clean subdirs-install > +.NOTPARALLEL: subdirs-all subdirs-clean subdirs-install No, .NOTPARALLEL in GNU Make causes parallelism to be globally disabled, not just for the listed dependent targets. It's really not the right answer here, and it allowed you in a later patch to break the dependencies in tools/firmware -- it may look neater to list subdirs-all as a dependency of all, but it's not correct in all cases! I applied your patches, then removed .NOTPARALLEL and fixed up the breakages. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |