Re: [Xen-devel] compat_mmuext_op - continuation code is wrong

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Wed, Feb 20, 2008 at 06:16:58PM +0000, Keir Fraser wrote:

> > But we never initialised the guest's "pdone" at any point. So we can
> > copy in an uninit stack value into 'done', add 'i' to it, then copy it
> > back out. On Solaris, we assert that the success count == what we passed
> > in, so this breaks Solaris 32/64
> > 
> > I'm running on 3.1 with a couple of fixes from unstable to make it work
> > at all. The below patch works for us but I'm not confident in its
> > correctness.
> 
> Better to remove the preempt check altogether, as it's already done
> (correctly) in do_mmuext_op(). That's what I'll check in.

That's what we initially tested, and works for us. Thanks.

john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel