Re: [Xen-devel] Bug in Linux dom0 netback?

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 05.02.08 11:03 >>>
>On 5/2/08 09:52, "Joakim Dahlstedt" <jda@xxxxxxx> wrote:
>
>> In Xen 3.1 the code in net_rx_action looked like this:
>> if (npo.mcl_prod &&
>>    !xen_feature(XENFEAT_auto_translated_physmap))
>> 
>> It seems like someone wanted to avoid the check in the if-statement and
>> turned it into a BUG_ON statement inside the if instead - but forgot to
>> invert the condition.
>> 
>> Can anyone confirm?
>
>Yes, that's a bug. It would only trigger with old domUs which have a
>netfront driver that does not have the new 'copying receiver' support. It
>was introduced by c/s 393 a couple of weeks ago.

Oh, yes, my bad.

>Thanks for tracking it down!

Keir, I assume you already created a fix to invert the condition...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel