[Xen-devel] Re: [PATCH] FP instruction in realmode emulation

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

I am surprised we get there: when emulating FPU instructions we first call
the ->load_fpu_ctxt hook, which calls vmx_do_no_device_fault() ->
setup_fpu() -> clts(). Obviously there is something going wrong though...
can you provide a backtrace?

Whatever the problem is, bear in mind that we should never take a FPU fault
from within Xen and if we do that is a bug in itself.

 -- Keir

On 1/2/08 00:12, "Nitin A Kamble" <nitin.a.kamble@xxxxxxxxx> wrote:

> Hi Keir,
>   Our QA team also found that the latest base kernel was failing on the
> new real mode emulation code. I looked into it, and found out the
> culprit to be guest_mode() call in the do_device_not_available handler.
>   This guest_mode() check over there is no more correct as the guest may
> run in hypervisor context in the form of emulation. The attached patch
> fixes this issue by removing the check. Another fix would be modifying
> the guest_mode() macro. What do you think, Is this check is needed there
> now ?
> 
> Signed-off-By: Nitin A Kamble <nitin.a.kamble@xxxxxxxxx>
>    



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel