[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] ioemu: handle empty vnc passwd

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 23 Jan 2008 18:06:15 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Delivery-date: Wed, 23 Jan 2008 10:07:16 -0800
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
Thread-index: Achd6qTh40XtNsndEdyZHgAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] ioemu: handle empty vnc passwd



On 23/1/08 17:49, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:

> On Wed, Jan 23, 2008 at 05:46:33PM +0000, Keir Fraser wrote:
>> If the only caller of xenstore_read_vncpasswd() is not checking the return
>> code, why continue to have xenstore_read_vncpasswd() return an error code at
>> all?
>> 
>> If that is fixed, and Daniel Berrange will ack the patch, then I'll take it.
> 
> ACK - patch gets my vote.

Okay, actually I can just fix up read_vncpasswd to return void myself.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

References:
- Re: [Xen-devel] [PATCH] ioemu: handle empty vnc passwd
  - From: Daniel P. Berrange

Prev by Date: Re: [Xen-devel] ioemu: empty vnc passwd
Next by Date: [Xen-devel] Finding Your Own Domain Id
Previous by thread: Re: [Xen-devel] [PATCH] ioemu: handle empty vnc passwd
Next by thread: [Xen-devel] [PATCH] ioemu: cache the BlockDriverState pointer
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.