[Xen-devel] [PATCH] avoid passing uninitialized ACPI tables to dom0 when checksums fail

[David Lively <dlively@xxxxxxxxxxxxxxx>]

If during boot, ACPI checksum failures disable ACPI support in Xen,
pass 'acpi=off' to the domain 0 kernel to avoid a fatal page fault
as domain 0 attempts to access the uninitialized ACPI tables.

Signed-off-by: David Lively <dlively@xxxxxxxxxxxxxxx>
Signed-off-by: Steve Ofsthun <sofsthun@xxxxxxxxxxxxxxx>

diff -r 0e884ef3b5bd xen/arch/x86/setup.c
--- a/xen/arch/x86/setup.c      Thu Oct 18 18:22:12 2007 -0400
+++ b/xen/arch/x86/setup.c      Thu Oct 18 18:22:12 2007 -0400
@@ -970,6 +970,11 @@ void __init __start_xen(unsigned long mb
         if ( acpi_skip_timer_override &&
              !strstr(dom0_cmdline, "acpi_skip_timer_override") )
             safe_strcat(dom0_cmdline, " acpi_skip_timer_override");
+        if ( (strlen(acpi_param) == 0) && acpi_disabled )
+        {
+            printk(KERN_WARNING "ACPI is disabled, notifying Domain 0\n");
+            safe_strcpy(acpi_param, "off");
+        }
         if ( (strlen(acpi_param) != 0) && !strstr(dom0_cmdline, "acpi=") )
         {
             safe_strcat(dom0_cmdline, " acpi=");

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel