Re: [Xen-devel] [PATCH] x86: consolidate/enhance TLB flushing interface

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 21/8/07 16:25, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Folding into a single local handler and a single SMP multiplexor as
> well as adding capability to also flush caches through the same
> interfaces (a subsequent patch will make use of this).
> 
> Once at changing cpuinfo_x86, this patch also removes several unused
> fields apparently inherited from Linux.

Applied at last. I just changed the names of a few functions and added a few
comments. Also, I don't know whether you empirically evaluated CLFLUSH
versus WBINVD, but your CLFLUSH loop was actually broken because 'sz' was in
pages rather than bytes. Hence you did not CLFLUSH a big enough area (by a
large margin) and hence you would vastly underestimate the cost of the
CLFLUSH approach.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel