[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH][HVM][SVM] Fix machine check intercept correctly
The documentation is unclear on what happens to #MC. Certainly it is held pending if GIF==0, but the manual does not explicitly say that #MC is held pending on vmexit. Is it possible to inject a #MC, to test what happens? That would be very handy, otherwise the code path basically gets no testing. :-) -- Keir On 1/10/07 17:17, "Woller, Thomas" <thomas.woller@xxxxxxx> wrote: > In theory the MCE that occurs in SVM partition, will be held pending > until the VMEXIT occurs, and then released when the STGI instruction is > executed, rendering any VMEXIT code non-useful. Same as the NMI > handling. I might be missing something here, but the do_machine_check() > will be executed in the context of the hv trap handlers immediately > after STGI instruction, so we don't want to call it twice in the vmexit > handler code. (?) > tom > >> -----Original Message----- >> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx >> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of >> Keir Fraser >> Sent: Monday, October 01, 2007 11:11 AM >> To: Egger, Christoph; xen-devel@xxxxxxxxxxxxxxxxxxx >> Subject: Re: [Xen-devel] [PATCH][HVM][SVM] Fix machine check >> intercept correctly >> >> On 1/10/07 16:33, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote: >> >>> Hi! >>> >>> Attached patch fixes machine check interception for HVM guests. >>> >>> Keir: Please apply this patch to xen-staging *and* to Xen 3.1.1 >> >> First chunk (adding TRAP_machine_check to exception >> intercepts) is not needed as that bit is already in >> HVM_TRAP_MASK. Also why remove the invocation of >> do_machine_check()? That is the function that actually >> handles the #MC. >> >> -- Keir >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@xxxxxxxxxxxxxxxxxxx >> http://lists.xensource.com/xen-devel >> >> >> > > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |