RE: [Xen-devel] [VTD-NEO][patch 5/6] Intel VT-d/Neocleus 1:1 mregedcode for PCI passthrough

["Kay, Allen M" <allen.m.kay@xxxxxxxxx>]

Gnntab_transfer changes were originally made by one of my colleagus for
supporting PV guest in another configuration.  We will resubmit this in
the future after we clean this up.

The reason we are checking for !hvm_domain in page_alloc() is for
setting up vt-d page tables for dom0 and PV domain.  Note that once vt-d
DMA translation is enabled, it applies to all domains.

VT-d page table for HVM domain is shared with p2m table.  It is setup by
vtd/intel-iommu.c/iommu_set_pgd() - call from p2m.c.  This is the reason
we don't need to do anything from hvm domain in page_alloc.c.

I was checking for vtd_enabled in common/page_alloc.c.  What is the
proper place to define this?   I will defer submission of common changes
until we reach an agreement on this.

I have split the remaining xen_misc.patch into following two pieces:

- io.patch      : ioport handling and 2 trivial header file changes
- xen_misc.patch: the remaining misc. xen changes.

Allen

Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx>
Signed-off-by: Guy Zana <guy@xxxxxxxxxxxx>

>-----Original Message-----
>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx] 
>Sent: Tuesday, September 18, 2007 7:18 AM
>To: Kay, Allen M; xen-devel@xxxxxxxxxxxxxxxxxxx
>Cc: Guy Zana
>Subject: Re: [Xen-devel] [VTD-NEO][patch 5/6] Intel 
>VT-d/Neocleus 1:1 mregedcode for PCI passthrough
>
>On 17/9/07 23:17, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:
>
>> These two patches contains miscellaneous xen and interrupt handling
>> changes contains in previous xen.patch.
>> 
>> xen_misc.c: miscellaneous collection of xen changes
>
>The changes to common code reference an x86-specific variable. 
>Also I don't
>see how the changes make sense. Gnttab_transfer is deprecated 
>so why would
>you care about modifying that path?  The changes in page_alloc.c are
>dependent on !hvm_domain(), but I thought the iommu changes were
>specifically to support PCI passthru for HVM domains?
>
> -- Keir
>

Attachment: io.patch
Description: io.patch

Attachment: xen_misc.patch
Description: xen_misc.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel