Re: [Xen-devel] [patch] Only skip the image name if it is the image name

[Keir Fraser <keir@xxxxxxxxxxxxx>]

Isn't that a kexec bug? Multiboot command lines include the image name in
all other cases. If there's no suitable name, perhaps a dummy name should be
included?

 -- Keir

On 28/8/07 10:34, "Simon Horman" <horms@xxxxxxxxxxxx> wrote:

> When kexecing the BOOT_IMAGE isn't provided on the second kernel's
> command line and thus cmdline_parse() was just skipping over
> the first parameter.
> 
> Observed on ia64
> 
> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> 
> Index: xen-unstable.hg/xen/common/kernel.c
> ===================================================================
> --- xen-unstable.hg.orig/xen/common/kernel.c 2007-08-28 18:24:54.000000000
> +0900
> +++ xen-unstable.hg/xen/common/kernel.c 2007-08-28 18:25:01.000000000 +0900
> @@ -37,8 +37,9 @@ void cmdline_parse(char *cmdline)
>      /* Skip whitespace and the image name. */
>      while ( *p == ' ' )
>          p++;
> -    if ( (p = strchr(p, ' ')) == NULL )
> -        return;
> +    if (! strncmp(p, "BOOT_IMAGE=", strlen("BOOT_IMAGE=")) )
> +        if ( (p = strchr(p, ' ')) == NULL )
> +            return;
>  
>      for ( ; ; )
>      {
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel