[Xen-devel] [PATCH]: Don't ask for a VNC password after HVM live migrate

[Chris Lalancette <clalance@xxxxxxxxxx>]

All,
     Attached is a simple patch to fix the VNC server in the qemu device model
after an HVM save/restore/migrate, if you don't have a vncpasswd specified.  The
basic problem was that the "image" section of the sxp had a "None" in it, which
means that on the restore (either on the local machine or remote machine), the
vnc server in the qemu device model literally needed the string "None" to
properly connect.  This simple patch only puts a vncpasswd entry in the image if
it is *not* None in the python code, thus avoiding the whole issue.

This patch is against 3.1.0, but should apply easily to xen-unstable.

Signed-off-by: Chris Lalancette <clalance@xxxxxxxxxx>

--- xen-3.1.0-src/tools/python/xen/xm/create.py.orig    2007-08-27 
16:41:39.000000000 -0400
+++ xen-3.1.0-src/tools/python/xen/xm/create.py 2007-08-27 16:42:44.000000000 
-0400
@@ -701,7 +701,8 @@ def configure_hvm(config_image, vals):
     for a in args:
         if (vals.__dict__[a]):
             config_image.append([a, vals.__dict__[a]])
-    config_image.append(['vncpasswd', vals.vncpasswd])
+    if vals.vncpasswd is not None:
+        config_image.append(['vncpasswd', vals.vncpasswd])
 
 def run_bootloader(vals, config_image):
     if not os.access(vals.bootloader, os.X_OK):

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel