[Xen-devel] Re: [PATCH] Xen i386 xen-head.S fix sections mixup (updated)

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

Mathieu Desnoyers wrote:
> Xen i386 xen-head.S fix sections mixup
>
> xen-head.S does not come back to the data section, leaving the text section
> as current section. It causes problems with a slightly enhanced DEBUG_RODATA
> that supports CONFIG_HOTPLUG and bringing a CPU up after the text has been
> marked read-only: reference to early_gdt_descr causes a page fault.
>
> Update:
>
> It should be using pushsection/popsection.
>   

Looks good, with one caveat below.

Acked-by: Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>

> -     .section .text
> +.pushsection .text
>       ELFNOTE(Xen, XEN_ELFNOTE_GUEST_OS,       .asciz "linux")
>       ELFNOTE(Xen, XEN_ELFNOTE_GUEST_VERSION,  .asciz "2.6")
>       ELFNOTE(Xen, XEN_ELFNOTE_XEN_VERSION,    .asciz "xen-3.0")
> @@ -34,5 +35,6 @@ ENTRY(hypercall_page)
>       ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE,       .asciz "no")
>  #endif
>       ELFNOTE(Xen, XEN_ELFNOTE_LOADER,         .asciz "generic")
> +.popsection
>   

Actually, the push/popsections around the ELFNOTEs are redundant;
ELFNOTE() does its own push/popsection to put things into the
appropriate .note* section anyway.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel