[Xen-devel] [PATCH] Fix xm block/network-detach command

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi,

This patch fixes a few problem of xm block/network-detach command. 

At first, when I tested xm block/network-detach command to a inactive 
managed domain, I saw the following error messages. 

# xm new /xen/vm1.conf
Using config file "/xen/vm1.conf".
# xm list --long vm1
(domain
 <snip>
    (device
        (vif
            (mac 00:16:3e:75:96:d8)
            (uuid ebd29601-41ac-75de-87cd-2ae051fa8719)
        )
    )
    (device
        (vbd
            (uuid 7572ae87-5706-217a-3fa5-f68496e147c1)
            (bootable 1)
            (driver paravirtualised)
            (dev hda1)
            (uname file:/xen/rhel4u2.root.img-vm1)
            (mode w)
        )
    )
)
# xm block-detach vm1 hda1
Error: Device hda1 not connected
Usage: xm block-detach <Domain> <DevId> [-f|--force]

Destroy a domain's virtual block device.
# xm network-detach vm1 0
Error: (22, 'Invalid argument, while reading None/device/vif/0/backend')
Usage: xm network-detach <Domain> <DevId> [-f|--force]

Destroy a domain's virtual network device.


I was able to fix the problem of inactive managed domains by writing 
a small patch.  However, I found a other problem in xm block/network-
detach command when I tested xm block/network-detach command more. 
The other problem is the same as the problem that Mats reported in 
the following. 

http://lists.xensource.com/archives/html/xen-devel/2007-08/msg00040.html

This patch fixes the other problem as follows. 
 - To remove device info, it waits for the backend path of the device 
   to be removed. 
 - It removes device info from domain info. 
 - It saves domain info to the config.sxp of the managed domain. 


Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

Attachment: xm_block_detach.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel