[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] [XEND] Modprobe vlan support before trying to use vconfig




xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 07/26/2007 09:43:57 AM:

> On Thu, Jul 26, 2007 at 09:47:42AM -0400, Stefan Berger wrote:
>
> > +def linux_enable_vlan():
> > +    global modprobed_8021q
>
> could this please go in osdep.py with the rest of the OS-specific
> stuff*, and just have an osdep.enable_vlan() function?


Now after these other two patches that I just committed, the problem with the vlan creation is gone and the only benefit of such a function osdep.enable_vlan() would be to print out a warning message into the log file to indicate that VLAN support is not available on the system (after a failed modprobe). Not sure whether it is worth such a function, though, but might be useful for debugging. Comments?

   Stefan

>
> thanks
> john
>
> * well, apart from all the new Linux-specific code there is...
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.