[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH]Clean up es7000 specific bootup code


  • To: "Subrahmanian, Raj" <raj.subrahmanian@xxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Tue, 10 Jul 2007 10:09:17 +0100
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 10 Jul 2007 02:07:12 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AceWvpt92gNeWwKxEdy09AAWy6hiGQCvyjGgABwt3PsA5BuyYAAY6zVDBDJNKuAAAO6/NAAAKlLGBPfZ+dAAEJl9bA==
  • Thread-topic: [Xen-devel] [PATCH]Clean up es7000 specific bootup code

Applied. And you'll see that I was able to strip out even more code, in
particular variable es7000_plat just disappeared.

Now I think we could go further, as es7000 now just looks like bigsmp. If we
got rid of the es7000 genapic altogether, would your systems always fall
back to bigsmp? If not, you might need to add a Unisys OEM check to the DMI
checks in arch/x86/genapic/bigsmp.c. But I think that would be a small
addition there, and allow you to completely remove all other vestiges of
es7000-specific code, making maintenance in future easier.

Could you look into this?

 -- Keir

On 10/7/07 02:47, "Subrahmanian, Raj" <raj.subrahmanian@xxxxxxxxxx> wrote:

> This patch cleans out Unisys es7000 platform specific code. A lot of the
> code there was not required since it is for legacy es7000s on which Xen
> is not supported.
> I also removed calls to enable_apic_mode from apic.c since that is also
> legacy es7000 specific code.
> This patch has been tested on a commodity Dell box and an Unisys es7000
> Raj
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.