Re: [Xen-devel] Question regarding SLAB corruption

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 9/7/07 19:37, "Lukas Hejtmanek" <xhejtman@xxxxxxxxxxx> wrote:

> On Mon, Jul 09, 2007 at 07:29:59PM +0100, Keir Fraser wrote:
>> Oh! I take it then that the infiniband driver will call sync_single() on
>> subsections of a mapped region? I haven't seen that behaviour before and it
>> will kill lib/swiotlb.c (the generic Linux swiotlb implementation) just as
>> surely as it does the Xen-specific swiotlb!
>> 
>> We could make the swiotlb robust to this treatment, I guess. It will involve
>> initialising all covered io_tlb_orig_addr[] slots rather than just the
>> first. You could even have a go at this yourself if you like: rather than
>> initialising a single slot at the end of map_single(), you'd have a for-loop
>> to iterate over each allocated swiotlb slab.
> 
> Is there a reason why this is not an issue in Dom0?

It should be an issue in dom0 just the same as in domU. You may get lucky in
dom0 and not use the swiotlb as much, as your dom0 is more likely to have a
physically contiguous memory map to start with.

Anyway, attahced is a patch I just applied to our unstable Linux tree. It
should fix this issue.

 -- Keir

Attachment: swiotlb.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel