Re: [Xen-devel] [PATCH 0/4] [Net] Support accelerated network plugin modules

[Michael Buesch <mb@xxxxxxxxx>]

On Friday 15 June 2007 13:26:03 Keir Fraser wrote:
> On 15/6/07 11:46, "Kieran Mansley" <kmansley@xxxxxxxxxxxxxx> wrote:
> 
> > This is a repost of some earlier patches to the xen-devel mailing list,
> > with a number of changes thanks to some useful suggestions from others.
> 
> The coding style needs fixing in various ways.
> 
> Hard tabs need to be used, no spaces inside brackets, but should include
> spaces between if/while/for and bracket, and bracket and brace:
>     if (foo) {
> Not
>     if( foo ){
>     if(foo ) {
> Or various other possibilities.
> 
> No use of the following please:
> If (foo) return 1; else return 0;
> Is clearer as:
> Return foo;

But it's not the same.
        return !!foo;
would be the same. And yes, it does matter:

int x(void)
{
        unsigned long long v = 0xFF0000000000ULL;
        /*foo*/
        return v;
}

-- 
Greetings Michael.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel